hamishgibbs / rt_vis

Interactive RT visualisation
3 stars 0 forks source link

Y axis max value #59

Open seabbs opened 4 years ago

seabbs commented 4 years ago

Should be min(max(observed data in window, top of ribbon in window) + a small amount, 5 * max(observed data in window)) I think

seabbs commented 4 years ago

Should hopefully avoid this sort of issue where blank space is most of the plot.

Screenshot 2020-10-05 at 16 42 30

hamishgibbs commented 4 years ago

I believe the 5 * max_obs_cases is currently defined by the max for that country (or region) overall but should be defined by the max for the country (or region) in the active time window.

seabbs commented 4 years ago

I don't think it is as the y axis updates as you filter. I think it just assumes that 5* observed cases is near the ribbon but sometimes we manage to not have such mad uncertainty 😆

hamishgibbs commented 4 years ago

Ah that's true. Ok I will look into what is going on. Thanks!