Erubis deprecated in Rails 5.1

haml / haml-rails

let your Gemfile do the talking

MIT License

1.04k stars 169 forks source link

Erubis deprecated in Rails 5.1 #121

Closed bknarendra closed 7 years ago

bknarendra commented 7 years ago

Template rendering moved to Erubi in Rails master, this generated a depreciation notice in the HAML gem:

DEPRECATION WARNING: ActionView::Template::Handlers::Erubis is deprecated and will be removed from Rails 5.2. Switch to ActionView::Template::Handlers::ERB::Erubi instead.

mohitnatoo commented 7 years ago

To add more context to the above description, the latest version of haml-rails seems to have dependency over haml version < 5.0. We'd need to make use of haml 5.0 instead.

sergiotapia commented 7 years ago

k0kubun commented 7 years ago

This is already resolved by https://github.com/indirect/haml-rails/pull/128 and https://github.com/haml/haml/commit/7577c187580b6b7a9fcd788c1d72b8894321334c. Use haml-rails 1.0 and haml 5.0.

And if you use :erb filter in Haml on Rails, you may want to use Haml 5.0.1 because of https://github.com/haml/haml/pull/914.

syguer commented 7 years ago

@k0kubun Thanks!