search

haml / haml-rails

let your Gemfile do the talking
MIT License
1.04k stars 169 forks source link

Only the latest Ruby + Rails versions #150

Closed radar closed 5 years ago

radar commented 5 years ago

Removing support for the older versions of Ruby + Rails will lessen maintenance burden of this project. I did it recently for i18n and really helped. A++ can recommend to others.

syguer commented 5 years ago

Absolutely agree! I did it for other gem too 😄

syguer commented 5 years ago

Should we continue to support for jruby?

radar commented 5 years ago

Yes, I think we should continue support for JRuby.

radar commented 5 years ago

I am not sure what is up with the JRuby build here. I do not see the same issues on i18n. I will need to investigate later.

scones commented 5 years ago

is there a chance this will get merged? i'd hate to reference an unmerged branch/PR in my gemfile for a prolonged time :)

amatsuda commented 5 years ago

I guess, keeping the jruby builds always green may not be this project's scope. jruby on Rails' CI is not always working healthily, and so in fact jruby has been treated as an "allow failure" platform there in the rails repo since almost 3.years.ago https://github.com/rails/rails/commit/ea628f72c3f6ef77752794356fcb358858fd8827

If that's the only reason we're not merging this PR, I'm :+1: to merge this as it is.

radar commented 5 years ago

Okay, going ahead and merging this PR.

radar commented 5 years ago

Version 2 of this gem has been released and has this patch.

amatsuda commented 5 years ago

FYI I just succeeded in making the CI :green_heart: again! https://github.com/indirect/haml-rails/commit/46a94f25693ed6f00386659293c0d1372261a7bd https://travis-ci.org/indirect/haml-rails/builds/498558176