search

haml / haml-rails

let your Gemfile do the talking
MIT License
1.04k stars 169 forks source link

Lower required_rubygems_version to 2 #154

Closed swaincreates closed 5 years ago

swaincreates commented 5 years ago

Heroku, AWS Beanstalk, and others dont have rubygems 3 yet (#153).

stephen-puiszis commented 5 years ago

Is there anything else that needs to be done to get this merged and released? I'd be happy to help out!

drewish commented 5 years ago

Yeah this is preventing me from using the gem.

abarrak commented 5 years ago

Me too. Waiting on the new release.

indirect commented 5 years ago

I'll see about releasing this.

amatsuda commented 5 years ago

@indirect Thank you for working on the release of the new version! I'm not sure if you're still willing to eagerly maintain this gem, but if you're not, we, the haml team are ready to take over the maintenance tasks.

Here's our rough plan.

  1. Move the repo under the haml organization
  2. Invite all the current maintainers of haml-rails (@indirect, @syguer, @radar, anyone else?) to the haml organization
  3. Move some Rails specific modules (e.g. Railtie, Action View monkey-patches, some helpers, etc.) and tests from haml to haml-rails (as we discussed several years ago...)

WDYT?

P.S. I know what I'm doing. I know I'm commenting on a closed issue instead of opening a new issue. I just thought that this place would be a nice channel to continue this kind of semi-public conversation within the people who are concerned with the release management.

indirect commented 5 years ago

@amatsuda yes, that sounds about right. If you have permission, go ahead and move this repo to the haml organization. If you don't, let me know, and I'll start the transfer.

amatsuda commented 5 years ago

@indirect Thank you! But unfortunately no, seems like I'm not an admin here...

indirect commented 5 years ago

@amatsuda ok. it seems I cannot give you admin access to my personal repo, and I cannot transfer to haml unless I have "create repo" permissions in the haml org. Can you give those permissions to me?

amatsuda commented 5 years ago

@indirect Done!

indirect commented 5 years ago

@amatsuda transferred!

amatsuda commented 5 years ago

@indirect Confirmed! Thank you very much!!