search

haml / haml-rails

let your Gemfile do the talking
MIT License
1.04k stars 169 forks source link

Haml 6 Support #180

Closed BilalBudhani closed 1 year ago

BilalBudhani commented 1 year ago

This PR enables upgrading to newly released Haml 6 https://github.com/haml/haml/releases/tag/v6.0.0

amatsuda commented 1 year ago

@BilalBudhani Thanks!

amatsuda commented 1 year ago

@indirect I tried to release a new gem with this update, but turned out that I do not have permission to push this gem. Could you either add me to the gem owners or publish a new release? Thank you in advance!

indirect commented 1 year ago

@amatsuda sorry about that! I’ve invited you to be an owner.

amatsuda commented 1 year ago

@indirect Thank you very much!

@BilalBudhani Just made a new gem release versioned 2.1.0 with this change. Thanks!

n00dle commented 1 year ago

Should this have resulted in a major version change for haml-rails? Upgrading to haml 6 broke some of ours views that still relied on the haml rails helpers that were available in 5.x.