haml / haml-rails

let your Gemfile do the talking
MIT License
1.04k stars 169 forks source link

edge rails argument error #68

Closed shaiguitar closed 10 years ago

shaiguitar commented 10 years ago

Fixes this error for rails 4.1.0rc1 ( or we could give it a default "html" in rails, but I just put this here because I got there error from haml-rails ).

  3) Error:
Haml::Generators::ScaffoldGeneratorTest#test_should_revoke_template_engine:
ArgumentError: wrong number of arguments (1 for 2)
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/railties-4.1.0.rc1/lib/rails/generators/erb.rb:20:in `filename_with_extensions'
    /Users/shair/projects/haml-rails/lib/generators/haml/scaffold/scaffold_generator.rb:10:in `block in copy_view_files'
    /Users/shair/projects/haml-rails/lib/generators/haml/scaffold/scaffold_generator.rb:9:in `each'
    /Users/shair/projects/haml-rails/lib/generators/haml/scaffold/scaffold_generator.rb:9:in `copy_view_files'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/command.rb:27:in `run'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:120:in `invoke_command'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `block in invoke_all'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `each'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `map'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `invoke_all'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/group.rb:233:in `dispatch'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:109:in `invoke'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/group.rb:278:in `block in _invoke_for_class_method'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/shell.rb:74:in `with_padding'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/group.rb:267:in `_invoke_for_class_method'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/group.rb:134:in `_invoke_from_option_template_engine'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/command.rb:27:in `run'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:120:in `invoke_command'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `block in invoke_all'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `each'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `map'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `invoke_all'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/group.rb:233:in `dispatch'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:109:in `invoke'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/group.rb:278:in `block in _invoke_for_class_method'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/shell.rb:74:in `with_padding'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/group.rb:267:in `_invoke_for_class_method'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/group.rb:134:in `_invoke_from_option_scaffold_controller'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/command.rb:27:in `run'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:120:in `invoke_command'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `block in invoke_all'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `each'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `map'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/invocation.rb:127:in `invoke_all'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/group.rb:233:in `dispatch'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/thor-0.18.1/lib/thor/base.rb:439:in `start'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/railties-4.1.0.rc1/lib/rails/generators/testing/behaviour.rb:66:in `block in run_generator'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/activesupport-4.1.0.rc1/lib/active_support/core_ext/kernel/reporting.rb:89:in `capture'
    /Users/shair/.rvm/gems/ruby-2.1.1/gems/railties-4.1.0.rc1/lib/rails/generators/testing/behaviour.rb:64:in `run_generator'
    /Users/shair/projects/haml-rails/test/lib/generators/haml/scaffold_generator_test.rb:20:in `block in '
indirect commented 10 years ago

Thanks for the patch! This is already fixed in 4-1-stable, though :) https://github.com/indirect/haml-rails/issues/66#issuecomment-37452973