hamlet-io / engine

Framework for managing cloud infrastructure via templates. It is part of the broader Hamlet devops framework.
GNU General Public License v3.0
5 stars 5 forks source link

Refactor - Storage Profiles in Azure Plugin #1775

Open RossMurr4y opened 4 years ago

RossMurr4y commented 4 years ago

Expected Behavior

Azure Storage Profiles should be established and used in alignment with other providers.

Current Behavior

Currently they appear to be working as desired in the Azure Provider but are not in alignment with the structure of the reference data type.

Expected structure of the Storage data type:

  "Storage": {
    "default": {
      "EC2": {
        "Volumes": {
          "codeontap": {
            "Device": "/dev/sdp",
            "Size": "30"
          }
        }
      }
    }
  }

Actual structure in Azure plugin masterdata:

"Storage": {
    "default": {
      "storageAccount": {
        "Tier": "Standard",
        "Replication": "LRS",
        "Type": "StorageV2",
        "AccessTier": "Cool",
        "HnsEnabled": false
      }
   }
}

Possible Solution

Either make use of the existing Storage reference data type structure or have the plugin provider specify its own.

Context

This appears to be currently working by accident in Azure and as such is fragile and likely to break over time.

roleyfoley commented 3 years ago

This is probably more appropriate as component specific configuration and also aligned with our shared definitions