search

hamlet-io / executor-bash

Executor for hamlet based on bash
GNU General Public License v3.0
0 stars 4 forks source link

Chore/cleanup resource groups #191

Closed RossMurr4y closed 3 years ago

RossMurr4y commented 3 years ago

Intent of Change

Description

Removes old configuration that would allow you to set the deployment resource group in the executor.

Motivation and Context

The Deployment Resource Group is now defined by the engine, and is not exposed to users to control.

How Has This Been Tested?

Template generation to ensure this does not impact creation of templates.

Followup Actions

ml019 commented 3 years ago

@RossMurr4y So if we are not controlling this, then the assumption is that all resource groups using the same placement will be included in a single template? Not an unreasonable assumption but want to ensure the intention is clear.

RossMurr4y commented 3 years ago

The term "Resource Group" is a little overloaded here and hopefully this PR will help clear that up too.

As I use it here in this PR, I am taking the "RESOURCE_GROUP" value that is known to Azure as a mandatory deployment target (you deploy resources/templates into a a resource group) and making it synonymous with STACK_NAME. Each DeploymentUnit will therefore get its own unique RESOURCE_GROUP to deploy into, following the same conventions used for STACK_NAME.

The relationship to the "ResourceGroup" known by the Hamlet Deploy Engine is coincidental, but not the target of the updates in this PR.