hamlet-io / executor-bash

Executor for hamlet based on bash
GNU General Public License v3.0
0 stars 4 forks source link

feat: user provided images #226

Closed roleyfoley closed 3 years ago

roleyfoley commented 3 years ago

Intent of Change

Description

Allows users to provided images through manageImages along with using the existing convention approach to discover the image

zip file based images can either be provided as a zip file with the .zip extension or as a directory which will be zipped up and used as the image. The path to the image files listed in the command are either relative to where the script is called from or an absolute path

To provide the image paths on manageImages the option -i is used

(o) -i IMAGE_PATHS     is list of paths to an image you want to provide to the registry

Each path provided aligns with a list of formats provided so if you provided lambda,spa the path order should be

<lambda path>,<spa path> 

docker images support either providing an existing docker tag of a local build or a Dockerfile and context path that will be used to build the image

on manageImages

(o) -d DOCKERFILE      is the path to a Dockerfile to build a docker image from
(o) -e DOCKER_CONTEXT  is the context directory to run the docker build from

These two work together to define a dockerfile to build inline with the standard docker build requirements

(o) -t DOCKER_IMAGE    is a docker tag of a built image to provide to the registry instead of a dockerfile

Is the name of an existing local image which has already been built and will be retagged and pushed to the registry

Motivation and Context

closes https://github.com/hamlet-io/executor-bash/issues/13 that allows users to define explicit images. This makes integration with existing build tools simple and also supports running across different build environments as required

How Has This Been Tested?

Will be tested on automation server once branch is available

Related Changes

Prerequisite PRs:

Dependent PRs:

Consumer Actions: