hamlet-io / executor-bash

Executor for hamlet based on bash
GNU General Public License v3.0
0 stars 4 forks source link

[BUG] Stack not saved on no change #238

Closed ml019 closed 3 years ago

ml019 commented 3 years ago

Current Behaviour

If there are no changes for a stack, the stack file is not saved unless it previously didn't exist - https://github.com/hamlet-io/executor-bash/blob/bcc947ab85bc531a9c1bbadc2260aac590449b29/cli/manageStack.sh#L305.

It used to be that the stack file was always fetched and saved regardless of whether the stack was unchanged or not.

Expected Behaviour

The stack should always be saved in case there were previous changes that weren't caught at the time they were made.

For example, if a manage segment job times out, it may have updated stacks but not saved the results. When next run, the template file will be found to be different and updated, but the stack file won't be retrieved as there is already one in the repo and cloud formation reported no changes.

Possible Solution

Remove the condition check for stack file existence.

Steps to Reproduce

  1. Run a job that updates a template but then times out
  2. Rerun the job successfully. If the only template changes are things that are ignored, then the regenerated template will be saved but the corresponding stack file won't.