feat: handle waf logging disable on delete

hamlet-io / executor-bash

Executor for hamlet based on bash

GNU General Public License v3.0

0 stars 4 forks source link

feat: handle waf logging disable on delete #260

Closed ken9ross closed 3 years ago

ken9ross commented 3 years ago

Intent of Change

Bug fix (non-breaking change which fixes an issue)

Description

This was to fix https://github.com/hamlet-io/engine-plugin-aws/issues/254

Motivation and Context

How Has This Been Tested?

Locally

Related Changes

Prerequisite PRs:

None

Dependent PRs:

None

Consumer Actions:

None

ken9ross commented 3 years ago

@roleyfoley It looks like I may have run off into the wild blue yonder (since I'm not even in the same repo as the issue was reported).

ken9ross commented 3 years ago

Those extra status are required on the check if you disable WAF logging (as distinct from disabling WAF, ie what I did in error but I believe is still a valid change)

roleyfoley commented 3 years ago

Can you remove it and try the same processes you test with. I cannot see how they could ever be in this state

ken9ross commented 3 years ago

Removed it and it worked, so I squashed and changed the commit message to align with conventional commits