fix(cli): disable paging for aws cli v2

hamlet-io / executor-bash

Executor for hamlet based on bash

GNU General Public License v3.0

0 stars 4 forks source link

fix(cli): disable paging for aws cli v2 #336

Closed ken9ross closed 2 years ago

ken9ross commented 2 years ago

Intent of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Description

Use envvar AWS_PAGER to eliminate paging in AWS CLI v2

Motivation and Context

Fixes https://github.com/hamlet-io/engine/issues/1972

How Has This Been Tested?

Locally

Related Changes

Prerequisite PRs:

None

Dependent PRs:

None

Consumer Actions:

None

ken9ross commented 2 years ago

I'm not certain if it was necessary, but the logic was that there are AWS commands in that script including "list" subcommands which I wasn't sure if could be impacted by the paging options being triggered. Purely a "better safe than sorry" choice.

Thoughts? Should I relocate it?

ml019 commented 2 years ago

I'm confused why you picked this script. It is determining access credentials whereas the setting would seem to be more generally about use of the cli. Would it be better to set it where it is determined that the account provider is AWS - I'm thinking in setContext ...

ken9ross commented 2 years ago

Done. My concern was the aws configure list in that script which was before(?) setContext was run in scripts like manageDocker manageRdssnapshot etc

ml019 commented 2 years ago

@ken9ross need to shift until after ACCOUNT_PROVIDER is determined around line 215.

ken9ross commented 2 years ago

I can't understand why that didn't trip my testing, but done