hamlphp / HamlPHP

Yet another Haml to HTML converter written in PHP.
http://hamlphp.github.com/HamlPHP
MIT License
84 stars 15 forks source link

The fix for the bug I told you and more #2

Closed svallory closed 13 years ago

svallory commented 13 years ago

I fixed the bug I've told you before and all tests are passing. As a consequence filters are skipping empty lines too. I.e. what was rendered as...



id now rendering as...
    <style type="text/css">
      body { color: #000; }
      p {
        color: #fff;
      }
      #container { color: #fff; }
    </style>

I don't think that's a problem since we won't work on the generated html or css. But we can go back to it later. Are you working on the interpolation yet? If you aren't, I can do it tomorrow. I don't know were you live, but I'm from Brazil and it's 1:30am now :) I'm gonna get some sleep and keep working on the parser tomorrow night. Also, I'm thinking about Sass and how we could use the same structure you've built to create a Sass parser. It's seems a lot more complicate since it has inheritance and other features.

Thank you for the great work on the parser, I think we can get it as good  the original one!

kind regards,
Saulo
sniemela commented 13 years ago

Nice! I'll merge this.

I'm working on the interpolation. I'll put the code to the hub when I'm done with the interpolation class, so you can continue to work on it if you want.

I'm from Finland and it's 2:20pm right now :)