search

hammadsaedi / regex-pro

Regex Pro is a regular expression tester. It allows you to test your regular expressions against a string of your choice.
https://hammadsaedi.github.io/regex-pro/
MIT License
6 stars 17 forks source link

feat: added phone number extraction to pages.js #32

Closed bryce-seefieldt closed 1 year ago

bryce-seefieldt commented 1 year ago

Here is a starting point for Issue 6.

This currently reads up to 12 characters and extracts a 10-12 digit phone number. I would really appreciate any guidance you can offer in terms of how you may want this regex to function. For example do you want it to ignore all non-numeric characters?

Please advise on how I can improve or customize to your goals. Thanks

hammadsaedi commented 1 year ago

It should have:

image

should not extract

image

bryce-seefieldt commented 1 year ago

Ok thanks for the feedback. I’ll address this asap.

On Mon, Oct 30, 2023 at 7:58 AM Hammad Saaedi @.***> wrote:

It should have:

  • country code (+92 / +123) or simple 0
  • 10 Digits

[image: image] https://user-images.githubusercontent.com/71373419/279047080-c90aee69-3ac8-45ce-89e0-4dcb4987ffd9.png

should not extract

[image: image] https://user-images.githubusercontent.com/71373419/279047151-28b19f1c-532a-4779-be78-3d91ec34cac3.png

— Reply to this email directly, view it on GitHub https://github.com/hammadsaedi/regex-pro/pull/32#issuecomment-1785034054, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6JISL572GVMKNLNT6WTSNLYB6I65AVCNFSM6AAAAAA6U7O3VCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVGAZTIMBVGQ . You are receiving this because you authored the thread.Message ID: @.***>

bryce-seefieldt commented 1 year ago

Updates made via new commit c4c41bb. Please let me know if this works for you.