hammedb197 / wikimedia_citation_classification

Wikimedia
0 stars 0 forks source link

Quick code review #1

Open eggpi opened 5 years ago

eggpi commented 5 years ago

Hi, thanks for this. Here's a couple of comments from a quick look:

/cc @mirrys @Samwalton9

hammedb197 commented 5 years ago

I didn't base my code on this it just coincidental that we used the same filename and error message. The name was inspired by the task description since we were expected to extract from Wiki Api and classify. The script also expects an output that's why I used input() text. Some other part of the code might be similar because it seems we both used the main repo

I am not handling sections that don't lead to the main section since Miriam stated here that we should use the section title at the highest level so that we can generalize across different articles.

Thanks.