search

hammem / monarchmoney

Python API for Monarch Money
MIT License
148 stars 26 forks source link

Adds methods to force account refreshes #49

Closed hammem closed 10 months ago

hammem commented 10 months ago

Addresses request in #43 to request a refresh of accounts by Monarch. Includes a convenience method to both make the request and poll to check if the request is completed.

hammem commented 10 months ago

@CalvinChanCan , please take a look and see if this is what you had in mind

lzilioli commented 10 months ago

Looks good to me! I have not had a chance to check out this branch and run it but code changes look good from my side. Will the caller need to pass the account ids as a parameter or do you generate that list yourself?

hammem commented 10 months ago

I was able to test all locally and it was working.

As of now, you have to get the accounts and pass them in.

I can update the convenience method to do the account list fetch as well, if not provided.

lzilioli commented 10 months ago

I believe that would be helpful. Would save me a line of code for my use case (since I want to refresh everything THEN fetch my accounts).

Thank you very much! Much appreciated.

hammem commented 10 months ago

@lzilioli , thanks for the feedback. Updated the PR to make the account_ids param in the convenience method optional.

lzilioli commented 10 months ago

Just tried it and it works great for me! Thanks. @hammem

CalvinChanCan commented 10 months ago

Thanks @hammem! That works perfectly well for me too!