hammer-tools / php-hammer

PHP Hammer is an inspections and tools plugin compatible with Intellij IDEA / PhpStorm.
Apache License 2.0
97 stars 3 forks source link

Incompatible with PHPStorm 2024.3 #66

Open francislavoie opened 3 days ago

francislavoie commented 3 days ago

Incompatible: requires IDE build 242.* or earlier

Would it make sense to change the version constraint to allow newer versions optimistically? Seems annoying to have to update it every time the IDE updates.

rentalhost commented 3 days ago

I am unsure if this is permitted by the JetBrains Plugin Manager, but it might be worth trying.

francislavoie commented 3 days ago

The other option is uploading new versions compat with the next one when it hits beta instead of on final release, then it would be ready ahead of time.

francislavoie commented 3 days ago

For sake of argument, I looked at some other plugins I have, this one does not specify an "until" version:

https://github.com/klesun/deep-assoc-completion/blob/274b5054ab65ecd23d51d1ab405c646d2988c589/resources/META-INF/plugin.xml#L57

So I think you could just remove until-build="242.*" and it should work indefinitely.

https://github.com/hammer-tools/php-hammer/blob/909e93282358b58d2ec506f9e4d839e0d0be2172/src/main/resources/META-INF/plugin.xml#L8