search

hammerjs / hammer-time

A fast click based on the touch-action css property
MIT License
100 stars 29 forks source link

Enhance detecting code for iOS8 and over #17

Closed sculove closed 8 years ago

sculove commented 8 years ago

https://github.com/hammerjs/hammer-time/blob/master/hammer-time.js#L34-L42 Is this a detecting code for iOS8 and over ?

Why don't you change code using indexedDB? http://caniuse.com/#search=indexedDB

Although iOS8,9 had a seriously bug, we can reduce code.

arschmitz commented 8 years ago

It is for that precisely. I know indexedDB does not work in iOS8 webviews so i'm not sure if this will work. Can you confirm if a feature detect for indexedDB shows support or not in an iOS 8 webview?

sculove commented 8 years ago

I check following code.

"indexedDB" in window

iOS7 webview returns 'false'. iOS8 webview returns 'true'. Unfortunately, iOS9 webview returns 'false'

arschmitz commented 8 years ago

Ok so it sounds like that wont work for detecting iOS8+ which is the intention

sculove commented 8 years ago

OK. I'll try to look for more different methods.

arschmitz commented 8 years ago

@sculove sounds good when i added this it was the best one i found but certainly open to improve.

sculove commented 8 years ago

I seem to find a different method. #18

arschmitz commented 8 years ago

merged pr