search

hammerlab / biokepi

Bioinformatics Ketrew Pipelines
Apache License 2.0
27 stars 4 forks source link

Control filename lengths #350

Closed smondet closed 8 years ago

smondet commented 8 years ago

This change is Reviewable

ihodes commented 8 years ago

Couple comments, LGTM overall; back to you!

Overall Q: how does a user figure out which of two `HASHBLAH-mutect-default.vcf" comes from, where one was e.g. indel realigned and one wasn't?

smondet commented 8 years ago

Overall Q: how does a user figure out which of two `HASHBLAH-mutect-default.vcf" comes from, where one was e.g. indel realigned and one wasn't?

Before this PR the "aggregate" naming was used only for quick debugging.

The user should always track the results their interested in (that's why they're always available in node "products" or, when EDSLing, in To_workflow.File_specification.t).

One day, we could offer more facilities to dump the Hashtbl.t to a file if needed.

ihodes commented 8 years ago

LGTM! This is a very helpful change 🙏