search

hammerlab / biokepi

Bioinformatics Ketrew Pipelines
Apache License 2.0
27 stars 4 forks source link

Update Vaxrank to 0.3.0 and its arguments/defaults #388

Closed ihodes closed 7 years ago

ihodes commented 7 years ago

fixes https://github.com/hammerlab/biokepi/issues/367

smondet commented 7 years ago

LGTM, just one question: are 2.x versions now totally irrelevant/useless? (if not we could have kept the code arround and manage both versions)

ihodes commented 7 years ago

Good point, but yeah, those old versions are completely superseded.

ihodes commented 7 years ago

Waiting on changes per https://github.com/hammerlab/epidisco/pull/105#issuecomment-265286924

ihodes commented 7 years ago

Okay, this is ready for final review!

ihodes commented 7 years ago

@smondet this is ready for merging—confirmed that it works.