Closed ihodes closed 7 years ago
From @smondet:
@tavinathanson it wouldn't be hard to implement (just look at the implementation of
Bfx.input
), then I'm not sure; maybe better doingBfx.save
to a directory and then, separately (throught Ketrew and the end of the pipeline or not), dogsutil rsync
of the whole thing
Probably would be a separate PR then?
@smondet @tavinathanson I think it's best we merge this in, then I can file some issues for
Does that seem reasonable?
@ihodes works for me if @smondet is cool with the code
@ihodes would love to use this in master, thoughts on getting it in?
@ihodes Travis says that you didn't update the src/examples/
:
module My_cluster = struct
let max_processors = 42
let work_dir = "/work/dir/"
let results_dir = "/results/dir/"
let datasets_home = "/datasets/"
let machine =
Biokepi.Setup.Build_machine.create "ssh://example.com/tmp/KT/"
end
File "./src/examples/edsl_extension_register_result.ml", line 269, characters 7-182:
Error: Signature mismatch:
...
The value `results_dir' is required but not provided
This is ready to merge, I think! /cc @smondet
@ihodes @smondet would love to use this in master today, so I vote for addressing anything else in a follow-up.
What would be the best way to support
Bfx.save
writing togs://
URLs?@smondet I see the gsutil_cp function; is there an existing function that knows to write either locally or via
gsutil
? How about privategs://
URLs?