hammerlab / biokepi

Bioinformatics Ketrew Pipelines
Apache License 2.0
27 stars 4 forks source link

First pass of "save" functionality #452

Closed ihodes closed 7 years ago

tavinathanson commented 7 years ago

What would be the best way to support Bfx.save writing to gs:// URLs?

@smondet I see the gsutil_cp function; is there an existing function that knows to write either locally or via gsutil? How about private gs:// URLs?

tavinathanson commented 7 years ago

From @smondet:

@tavinathanson it wouldn't be hard to implement (just look at the implementation of Bfx.input), then I'm not sure; maybe better doing Bfx.save to a directory and then, separately (throught Ketrew and the end of the pipeline or not), do gsutil rsync of the whole thing

tavinathanson commented 7 years ago

Probably would be a separate PR then?

ihodes commented 7 years ago

@smondet @tavinathanson I think it's best we merge this in, then I can file some issues for

  1. supporting writing to gs://
  2. generating a csv manifest
  3. generating the .json files alongside the saved products

Does that seem reasonable?

tavinathanson commented 7 years ago

@ihodes works for me if @smondet is cool with the code

tavinathanson commented 7 years ago

@ihodes would love to use this in master, thoughts on getting it in?

smondet commented 7 years ago

@ihodes Travis says that you didn't update the src/examples/:

module My_cluster = struct

  let max_processors = 42

  let work_dir = "/work/dir/"

  let results_dir = "/results/dir/"

  let datasets_home = "/datasets/"

  let machine =

    Biokepi.Setup.Build_machine.create "ssh://example.com/tmp/KT/"

end

File "./src/examples/edsl_extension_register_result.ml", line 269, characters 7-182:

Error: Signature mismatch:

       ...

       The value `results_dir' is required but not provided
ihodes commented 7 years ago

This is ready to merge, I think! /cc @smondet

tavinathanson commented 7 years ago

@ihodes @smondet would love to use this in master today, so I vote for addressing anything else in a follow-up.