search

hammerlab / cohorts

Utilities for analyzing mutations and neoepitopes in patient cohorts
Apache License 2.0
20 stars 4 forks source link

Fixing filter cache issues #196

Closed tavinathanson closed 7 years ago

tavinathanson commented 7 years ago

Could probably use more tests, but how does this look for now?

tavinathanson commented 7 years ago

@jburos added another fix: checking for None to avoid calling _hash_filter_fn on None.

tavinathanson commented 7 years ago

Can't wait for https://github.com/hammerlab/cohorts/issues/175!

tavinathanson commented 7 years ago

Fixes https://github.com/hammerlab/cohorts/issues/195

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.5%) to 56.246% when pulling 3c1e23f44f6cb4cd11ca71b8490d4e67e354987d on fix_filter_cache_warning into b47b8eff2250f42324e3da6296fa4a5bfb032923 on master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-1.5%) to 56.246% when pulling 3c1e23f44f6cb4cd11ca71b8490d4e67e354987d on fix_filter_cache_warning into b47b8eff2250f42324e3da6296fa4a5bfb032923 on master.

tavinathanson commented 7 years ago

@jburos oops, looks like this one was forgotten by both of us; can you take a look?