Closed tavinathanson closed 7 years ago
@jburos I think I addressed your comments, lmk!
@jburos turns out pysam
0.9.0
, which we conda install
in Travis (https://github.com/hammerlab/cohorts/pull/49#issuecomment-225646603), requires 3.4.
So, instead, I made it >= 0.9.0
and also added pysam
to our requirements.txt
(since we do directly use it now). I also removed 3.3
from Travis, since no current version of pysam
on Conda
appears to support 3.3
.
Hopefully that'll all work.
No longer support Python 2, including:
python_requires
constraint insetup.py
.Also update 2016 to 2017 in files.
I figured we should go all out and not allow Python 2 usage at all if we're no longer testing with Python 2. Otherwise, issues like
str
vs.unicode
resulting in the wrong number of patients in theCohort
will be highly likely.