search

hammerlab / cohorts

Utilities for analyzing mutations and neoepitopes in patient cohorts
Apache License 2.0
20 stars 4 forks source link

Fix RGBA error with plot_survival #223

Closed jburos closed 7 years ago

jburos commented 7 years ago

Address issue #221, by which an error is raised on lifelines version >= 0.9.3.2. Though, to be fair, it's not clear if the error is due to matplotlib or lifelines.

We will fix the error for those versions of lifelines & incrementing the requirements to depend on more recent versions of lifelines.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.08%) to 56.871% when pulling de16b7d17048b8eff58fe651a77a0c7e1c190d08 on fix-issue-221-rebase into 31545c4b03d9a1edd9cc543ac1f863a140e88cd8 on master.

jburos commented 7 years ago

This is a good point - increasing the version to 0.10+ would also fix this. Though in general I try to keep requirements as flexible as possible in case of conflicts. What do you think, would it be cleaner to force a more recent version?