Update warning and associated comment

hammerlab / cohorts

Utilities for analyzing mutations and neoepitopes in patient cohorts

Apache License 2.0

20 stars 4 forks source link

Update warning and associated comment #230

Closed tavinathanson closed 7 years ago

tavinathanson commented 7 years ago

Add a bit of clarity w.r.t. the StopIteration catch.

tavinathanson commented 7 years ago

@jburos yeah, we had an issue like that a while ago, where we accidentally cached something when we hit an error and then it was just empty with no error after that. At least, here, we should generally only be doing that when it's an empty VCF.

That said, it does feels somewhat error-prone. I'll file an additional issue about that.

coveralls commented 7 years ago

Coverage remained the same at 53.291% when pulling d737a0e3b0727cc4197026a12cb06861abb36722 on stopiteration_warning into e61e9763bc0b64b2c728fffb08fc7a68e0a645ff on master.