add `join_on_left` parameter to dataframe_loader - Githubissues

hammerlab / cohorts

Utilities for analyzing mutations and neoepitopes in patient cohorts

Apache License 2.0

20 stars 4 forks source link

add `join_on_left` parameter to dataframe_loader #242

Closed jburos closed 7 years ago

jburos commented 7 years ago

Allows a dataframe to merge with the cohort on a field other than patient_id.

In one of our projects, the extraneous data are sometimes labelled by sample_id, which is a different identifier than patient id. Allowing a join_on_left parameter seems cleaner than merging-in a patient_id identifier for each of these external dataframes.

(I'm not really happy with the name of this parameter, but the functionality would be useful).

coveralls commented 7 years ago

Coverage increased (+0.03%) to 53.284% when pulling 4b41ebf7fd8cd792c2c7349834f512bdb0d8039b on join-on-left into 692652307e339826bdd13253efd1e7b208e34b37 on master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 53.284% when pulling 4b41ebf7fd8cd792c2c7349834f512bdb0d8039b on join-on-left into 692652307e339826bdd13253efd1e7b208e34b37 on master.

coveralls commented 7 years ago

Coverage increased (+0.03%) to 53.284% when pulling 4b41ebf7fd8cd792c2c7349834f512bdb0d8039b on join-on-left into 692652307e339826bdd13253efd1e7b208e34b37 on master.

coveralls commented 7 years ago

Coverage increased (+0.1%) to 53.399% when pulling cfc23877dcff5e58f24509b2245e23f500926dd4 on join-on-left into 692652307e339826bdd13253efd1e7b208e34b37 on master.

jburos commented 7 years ago

@tavinathanson made what i think are the requested changes on this - do you mind taking a look?

coveralls commented 7 years ago

Coverage increased (+0.1%) to 53.399% when pulling fd68e2f275fe1724fe45538ac68811b554392b1f on join-on-left into 692652307e339826bdd13253efd1e7b208e34b37 on master.