Use the newest version of pileup with require support

[armish]

• upgrade pileup.js to v0.1.4 and access the module with require('pileup') instead of depending on global variables
• when bundling the source, reactify globally so that dependencies also get transformed (the new pileup.js needs this until we resolve this issue: https://github.com/hammerlab/pileup.js/issues/188)
• upgrade the uglifyify as the older version was not able to minify React properly causing conflicts across pileup.js and Cycledash instances

[ihodes]

Nice!

On Fri, Jun 12, 2015 at 7:02 PM, B. Arman Aksoy notifications@github.com wrote:

• upgrade pileup.js to v0.1.4 and access the module with require('pileup') instead of depending on global variables
• when bundling the source, reactify globally so that dependencies also get transformed (the new pileup.js needs this until we resolve this issue: https://github.com/hammerlab/pileup.js/issues/188)
• upgrade the uglifyify as the older version was not able to minify React properly causing conflicts across pileup.js and Cycledash instances You can view, comment on, or merge this pull request online at: https://github.com/hammerlab/cycledash/pull/726 -- Commit Summary --
  • support for new pileup version that allows require calls

  • update uglifyify version to prevent React minification errors -- File Changes -- M cycledash/static/js/examine/components/PileupViewer.js (3) M gulpfile.js (9) M package.json (4) -- Patch Links -- https://github.com/hammerlab/cycledash/pull/726.patch https://github.com/hammerlab/cycledash/pull/726.diff

    Reply to this email directly or view it on GitHub: https://github.com/hammerlab/cycledash/pull/726

[armish]

It took me a while to fix the React clashing problem, but turns out it was just uglifyify's old implementation that was behaving badly :\

Have a nice weekend and safe travels, @ihodes!

[danvk]

@armish is this good to merge? Or do you want to find a different (flow compatible) way to resolve the browserify issues?

[armish]

@danvk haven't resolved the flow issue yet. Other than the flow issue, this works fine; but, feel free to hold off from merging this before we completely resolve issues on pileup.js side.

[danvk]

Let's go ahead and merge this—it should be the same after we fix things up on the pileup side.

Could you check what the size of cycledash/static/js/dist/bundled.js is before & after this change? I'm hoping that this results in Cycledash and pileup.js sharing copies of React, D3 and underscore.

[armish]

unfortunately this changeset does not make them share those libraries yet, as pileup.js is still included as a bundled file with all the libraries in it. The size of the bundled.js was 620K before the changes and it is now ~1M. The new uglifyify seems to be doing a worse job :\