search

hammerlab / cycledash

Variant Caller Analysis Dashboard and Data Management System
Other
35 stars 2 forks source link

Update screenshots to fix broken CI tests on Travis #814

Closed armish closed 9 years ago

armish commented 9 years ago

For some reason unknown to me, our CI tests were failing us due to differing screenshots. See this trivial change in the README file and the corresponding fail report from Travis.

A few pages were off had different renderings of button corners (like run pages). I am not sure why these need an update, but might be due to an update on the Sauce Labs side that affected renderings.

This is to bring the screenshots up-to-date and resolve issues with Travis.

Review on Reviewable

armish commented 9 years ago

FYI: I will merge this trivial one in and continue working on the other ones.

ihodes commented 9 years ago

Sorry I didn't get to this earlier! The ./update-screenshots.sh script needs to be reverted to the way it was before; cf. my comment on it.

I'm not quite sure, but it looks like the issue was sparked this PR was fixed (timestamp issues?), and the screenshots needed to be changed in the end just because of the Chrome version bump to 44?