Closed armish closed 9 years ago
is there a test you could add that would have caught this mistake?
yeah, it should do be doable using one of the test files we have. Let me add that and update the PR.
Adding a download test was much harder than I expected (due to some magic happening with authentication), but this is done now. On the bright side: we now have support for basic authentication for all pages within Cycledash.
Looks great! One minor comment.
Looks good!
Thanks!
See #738 for more context.
When clicked on the download, we were getting this error logged:
which was stemming from a simple coding mistake.