Update to React 0.14 - Githubissues

hammerlab / cycledash

Variant Caller Analysis Dashboard and Data Management System

Other

35 stars 2 forks source link

Update to React 0.14 #858

Closed danvk closed 8 years ago

danvk commented 8 years ago

Highlights:

React → ReactDOM
Drop many .getDOMNode() calls
React.addons.classSet → require('classnames')
React.addons.TestUtils → require('react-addons-test-utils')
ReactClass.type → ReactClass
Updated to pileup@0.5.1

ihodes commented 8 years ago

Thanks for debugging this. Is it worth doing this in two steps? Seems like the 0.13 change is just a massive regression in terms of functionality, would be better to do 0.12→0.14. Are you planning on upgrading this to 0.14 right away?

danvk commented 8 years ago

Yeah, good point. I'll update to 0.14 and push another commit to this branch.

ihodes commented 8 years ago

Cool, sounds good, thanks!

danvk commented 8 years ago

This depends on the next version of pileup (see https://github.com/hammerlab/pileup.js/issues/246), which I hope to release tomorrow.

ihodes commented 8 years ago

LGTM, thanks for doing this!