search

hammerlab / cycledash

Variant Caller Analysis Dashboard and Data Management System
Other
35 stars 2 forks source link

Don't look for BAMs on HDFS #865

Closed ihodes closed 8 years ago

ihodes commented 8 years ago

Instead, BAM URLs are now just HTTP(s) URLs pointing anywhere.

Addresses https://github.com/hammerlab/cycledash/issues/791

If we don't want to break links on the deployed Cycledash when we push this change, we'll need to add http://hammerlab-dev3.hpc.mssm.edu:9876 in front of all our existing BAM URIs.

Review on Reviewable

danvk commented 8 years ago

Review status: 0 of 12 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

API.md, line 33 [r1] (raw file): URI or URL? (The field name is one but the documentation is the other.)

cycledash/api/bams.py, line 70 [r1] (raw file): This can't be true if the BAM is just available via HTTP...

cycledash/templates/about.html, line 35 [r1] (raw file): not implemented yet?

Comments from the review on Reviewable.io

ihodes commented 8 years ago

Review status: 0 of 13 files reviewed at latest revision, 1 unresolved discussion.

API.md, line 33 [r1] (raw file): It's a URL now; previously it was a URI (just the path on HDFS). A URI is a subset of a URL, so I figured I'd keep it the same on the backend http://stackoverflow.com/questions/176264/what-is-the-difference-between-a-uri-a-url-and-a-urn

Comments from the review on Reviewable.io

danvk commented 8 years ago

LGTM

Review status: 0 of 13 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

cycledash/api/bams.py, line 84 [r1] (raw file): How about deleting this worker, too?

Comments from the review on Reviewable.io