search

hammerlab / genspio

Generate Shell Phrases In OCaml
https://smondet.gitlab.io/genspio-doc/
Apache License 2.0
48 stars 3 forks source link

Update please to use dune #104

Closed raphael-proust closed 4 years ago

raphael-proust commented 4 years ago

Fixes #103

Note that I haven't tested with all the available version of dune. I have tested on 1.11.something and on 2.2.0. In both cases, there are warnings (27: unused variable, and 34: unused type), but it does compile.

I'm not sure how to executes the tests though. I'll look it up later.

raphael-proust commented 4 years ago

Also note that dependency nonstd also depends on jbuilder so a similar change is also needed there to complete the dependency upgrade.

smondet commented 4 years ago

@raphael-proust thanks (in nonstd it is already in master, but I wonder if this is the ocasion to ditch that dependency and use base)