hammerlab / guacamole

Spark-based variant calling, with experimental support for multi-sample somatic calling (including RNA) and local assembly
Apache License 2.0
84 stars 21 forks source link

travis scoverage attempt #564

Closed ryan-williams closed 8 years ago

ryan-williams commented 8 years ago

fixes #244

This change is Reviewable

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling fe3c712d84033de768c6bac516cc03247bbeed67 on ryan-williams:scoverage into \ on hammerlab:master**.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling fe8e1e93ae473508ff19fbd5129648b7f3aac316 on ryan-williams:scoverage into \ on hammerlab:master**.

e5c commented 8 years ago

LGTM!


Reviewed 3 of 3 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

arahuja commented 8 years ago

Did you have to add something locally to run this?

I tried

mvn clean
mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V
mvn scoverage:report

I get

[ERROR] No plugin found for prefix 'scoverage' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/Users/arahuja/.m2/repository), central (https://repo.maven.apache.org/maven2)] -> [Help 1]
ryan-williams commented 8 years ago

You need -Pcoverage for scoverage:report or coveralls:report to be availble.

Also coveralls:report will need coveralls <repoToken/>, which we're not supposed to put into the git history, but you can get from https://coveralls.io/github/hammerlab/guacamole (I'm assuming only hammerlab org can see the token on that page…).

arahuja commented 8 years ago

You need -Pcoverage for scoverage:report

Ah interesting, any reason the travis script doesn't need that?

ryan-williams commented 8 years ago

Yea, sry I should have mentioned that -Pcoverage is also activated by env.TRAVIS; that predates this change (though that whole profile has been defunct for a long time).

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling a4d0e4eed0c173ec581bc2d67e2028266f5dda92 on ryan-williams:scoverage into \ on hammerlab:master**.

arahuja commented 8 years ago

@ryan-williams All set with this?

ryan-williams commented 8 years ago

I believe so! Sorry, didn't see a "lgtm" or equivalent so wasn't sure if you wanted another look