Closed ryan-williams closed 8 years ago
LGTM!
Reviewed 3 of 3 files at r1, 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Did you have to add something locally to run this?
I tried
mvn clean
mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V
mvn scoverage:report
I get
[ERROR] No plugin found for prefix 'scoverage' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (/Users/arahuja/.m2/repository), central (https://repo.maven.apache.org/maven2)] -> [Help 1]
You need -Pcoverage
for scoverage:report
or coveralls:report
to be availble.
Also coveralls:report
will need coveralls <repoToken/>
, which we're not supposed to put into the git history, but you can get from https://coveralls.io/github/hammerlab/guacamole (I'm assuming only hammerlab org can see the token on that page…).
You need -Pcoverage for scoverage:report
Ah interesting, any reason the travis script doesn't need that?
Yea, sry I should have mentioned that -Pcoverage
is also activated by env.TRAVIS
; that predates this change (though that whole profile has been defunct for a long time).
@ryan-williams All set with this?
I believe so! Sorry, didn't see a "lgtm" or equivalent so wasn't sure if you wanted another look
fixes #244
This change is