Move logging to grizzled slf4j

hammerlab / guacamole

Spark-based variant calling, with experimental support for multi-sample somatic calling (including RNA) and local assembly

Apache License 2.0

83 stars 21 forks source link

Move logging to grizzled slf4j #570

Closed arahuja closed 7 years ago

arahuja commented 7 years ago

In prep for Spark 2.0 upgrade, this moves the references to o.a.s.Logging to to grizzled's scala slf4j wrapper which similarly provides a Logging trait

Another option could be https://github.com/typesafehub/scala-logging with LazyLogging trait, but that doesn't have scala 2.10 version

This change is

coveralls commented 7 years ago

Coverage remained the same at 75.198% when pulling 5df668e557524e4073cd3265b7c45d11fdd773ef on logging into ba0942c3410d0c35106374c882438da3fae23552 on master.

e5c commented 7 years ago

Review status: 0 of 9 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

ryan-williams commented 7 years ago

lgtm modulo couple things I sent you in #573