likelihood nits - Githubissues

hammerlab / guacamole

Spark-based variant calling, with experimental support for multi-sample somatic calling (including RNA) and local assembly

Apache License 2.0

83 stars 21 forks source link

likelihood nits #574

Closed ryan-williams closed 7 years ago

ryan-williams commented 7 years ago

goes on top of #571

private-ize a few methods
simplify alignment-inclusion API in likelihood calculation: simple boolean instead of arbitrary function
remove "Likelihood." from call-sites
misc line-spacing

I can make this a separate PR if you don't want to combine it with #571 / things here are controversial, @arahuja, lmk!

This change is

coveralls commented 7 years ago

Coverage decreased (-0.002%) to 75.586% when pulling b1bef5c42cb96099671111e9184c4d6143a5a303 on ryan-williams:likelihood into 0dedb7ef408d40871abb7811e3d8f236d3826fd9 on hammerlab:somatic-standard-upgrades.

arahuja commented 7 years ago

Thanks!