search

hammerlab / guacamole

Spark-based variant calling, with experimental support for multi-sample somatic calling (including RNA) and local assembly
Apache License 2.0
84 stars 21 forks source link

Move commons-io back to standard dep #577

Closed arahuja closed 8 years ago

arahuja commented 8 years ago

At some point, commons-io was moved to a test-only dependency, but this is necessary as a dependency when running without spark-submit for Hadoop output.

This change is Reviewable

ryan-williams commented 8 years ago

heh, just did this locally as well.

Seems like it being present as a test dep was enough to omit it from being picked up as a trans-dep by all dependencies (including Spark, which needs it), but then it doesn't make it into the packaged JAR because it's only a test dep.

Feels like broken decisions in the Maven stack, but yea lgtm