hammerlab / guacamole

Spark-based variant calling, with experimental support for multi-sample somatic calling (including RNA) and local assembly
Apache License 2.0
83 stars 21 forks source link

rm "-fasta" from reference-param name #580

Closed ryan-williams closed 7 years ago

ryan-williams commented 7 years ago

it can be a .fasta.gz, making the previous name a bit ambiguous, and both previous ref args were unnecessarily verbose


This change is Reviewable

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.06%) to 78.628% when pulling 8295cae38881818a179a1b5f034b002c66b784e1 on ryan-williams:ref into a6771eeafed073e6858979e01b214b214d965a1f on hammerlab:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling d2b0fb19b814002071af8ec123d989b3b77fc07e on ryan-williams:ref into \ on hammerlab:master**.

arahuja commented 7 years ago

This PR seems like it was merged in already? The diff is empty except for an empty line removed?

ryan-williams commented 7 years ago

Weird, yea this commit ended up on #579; I don't think that was intentional / know when it was added there relative to your review, sorry!

Let me know if you have any comments on it!