hammerlab / guacamole

Spark-based variant calling, with experimental support for multi-sample somatic calling (including RNA) and local assembly
Apache License 2.0
83 stars 21 forks source link

lots of pom, shading, scripts improvements #589

Closed ryan-williams closed 7 years ago

ryan-williams commented 7 years ago
arahuja commented 7 years ago

Looked fine to me - but looks like there are some travis issues?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 78.853% when pulling 603ec24eea64147f906f0e57c06876f71226c901 on ryan-williams:ss into 5fff3ea1bfbe877870a87d68d49b5b09c0a8a7ef on hammerlab:master.

ryan-williams commented 7 years ago

Yea, something about how a dep conflict was being resolved was apparently shaken loose with making the spark/hadoop deps provided by default; I think I've got it explicitly set in a consistent/working way now… thanks for the review, lmk if you have any thoughts about how I resolved it.