Closed arahuja closed 8 years ago
Looks great, thanks for cleaning all this up.
While reviewing I was inspired to do a further loci-parsing refactor that I'd attempted and failed a few times in the past, but finally cracked this time: #606.
A couple small things in #606 are separable and more like bona-fide tweaks to what is here, but on the whole it's a separate PR and can be reviewed/merged as such.
I opened #606 against this in case you want to merge it in here, but if not you can just merge this and I'll send out #606 as a fresh PR.
This PR:
PileupFilter
files and usage fromSomaticStandard
ReadFilterArgs
which has flags to set properties ofInputFilters
LociArgs
andReadFilterArgs
tied to read inputs hierarchy as opposed to partitioning.InputFilters
to tie in with arg-parsing and removing some defaultsLociParser
result inNone
when no loci are specified and removing thefallback
arguments as sometimes this strings were incorrectly specified.InputFilters
in a few cases. In https://github.com/hammerlab/guacamole/commit/3bcca667bd506a8eba5f85951f2856ccbe899f70SomaticStandard
went from removing duplicate and failed reads to including them because of a default filter argument, so I wanted to avoid that.