hammerlab / guacamole

Spark-based variant calling, with experimental support for multi-sample somatic calling (including RNA) and local assembly
Apache License 2.0
83 stars 21 forks source link

Remove PileupFilter and revamp InputFilters #605

Closed arahuja closed 7 years ago

arahuja commented 7 years ago

This PR:

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.5%) to 79.169% when pulling e27ba66219fa007776e723186c2532d408c4630f on read-filters into dfdfea6c9bda4040a7dd67decb862d9988b9c33c on master.

ryan-williams commented 7 years ago

Looks great, thanks for cleaning all this up.

While reviewing I was inspired to do a further loci-parsing refactor that I'd attempted and failed a few times in the past, but finally cracked this time: #606.

A couple small things in #606 are separable and more like bona-fide tweaks to what is here, but on the whole it's a separate PR and can be reviewed/merged as such.

I opened #606 against this in case you want to merge it in here, but if not you can just merge this and I'll send out #606 as a fresh PR.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.09%) to 78.745% when pulling c3831f4f2a1a9bfe4957cc6fa1530df340e05a53 on read-filters into dfdfea6c9bda4040a7dd67decb862d9988b9c33c on master.