hammerlab / stratotemplate

DEPRECATED: we don't really maintain this any more, we use Coclobas:
https://github.com/hammerlab/coclobas
Apache License 2.0
2 stars 0 forks source link

Make configuration.env easier to get right #22

Open hammer opened 7 years ago

hammer commented 7 years ago
ihodes commented 7 years ago

Could use better commenting, but PREFIX is typically something descriptive (rather than random) like "hammer-strato", as it'll show up as the prefix for the cluster name in the GCP instance list.

TOKEN could certainly be autogenerated with a Make file or something.

GCLOUD_HOST is the specific gcloud dev node that'll be the jumping-off point for the strato cluster, so this must be filled in by the user specifically.

hammer commented 7 years ago

GCLOUD_HOST is the specific gcloud dev node that'll be the jumping-off point for the strato cluster, so this must be filled in by the user specifically.

Well I just ran whomai and hostname on my GCE image and put the results where the placeholders were located. Why couldn't a script do that?

ihodes commented 7 years ago

Good point; forgot the names are the same! Definitely nice to generated as much of the config as possible.

smondet commented 7 years ago

Yes I thought of generating it but, feared that people may deviate a little bit from the instructions and then break it very easily.

arahuja commented 7 years ago

Well I just ran whomai and hostname on my GCE image and put the results where the placeholders were located. Why couldn't a script do that?

Also depends on where this is done. I also thought this was the case but would be different when running inside the docker container

hammer commented 7 years ago

Also depends on where this is done.

Good point, modified it to indicate where that simplification could be performed