search

hammerlab / survivalstan

Library of Stan Models for Survival Analysis
Apache License 2.0
124 stars 23 forks source link

Possible log_t_dur misspecification in Stan model file #71

Closed lzachmann closed 5 years ago

lzachmann commented 6 years ago

Hi Jacqueline, just wanted to flag a *possible* error at Line 42 in your 'pem_survival_model_unstructured.stan' model:

https://github.com/hammerlab/survivalstan/blob/master/survivalstan/stan/pem_survival_model_unstructured.stan#L42

It's entirely possible I'm wrong, but it may need to be: log_t_dur = log(t_dur);. Wasn't recovering the right baseline hazard without it.

Thanks, and great repo!

jburos commented 6 years ago

Yes - thank you for catching this! I will fix it now.