Closed timodonnell closed 7 years ago
Looks fine to me, the variable substitution seems a bit weird, does it add much over just using environment variables directly?
Thanks @arahuja . Pushed a commit addressing these.
I'd like to find an off the shelf configuration library that does variable substitition but haven't found one unfortunately (YAML doesn't do it), so I think I'll stick with the current hacky system for now
THIS_DIR
substitution available that gives the absolute path to the directory of the current JSON file. No moreConfigDict
object. We now resolve all substitutions when loading the config and return a plain dict.demeter.json
. May have to update for gcloud.demter.json
setsYARN_CONF_DIR
andSPARK_HOME