hammerlab / variant-calling-benchmarks

Automated and curated variant calling benchmarks for Guacamole
Apache License 2.0
2 stars 1 forks source link

Better configuration system, configurable `spark-submit` and env vars #31

Closed timodonnell closed 7 years ago

timodonnell commented 7 years ago
arahuja commented 7 years ago

Looks fine to me, the variable substitution seems a bit weird, does it add much over just using environment variables directly?

timodonnell commented 7 years ago

Thanks @arahuja . Pushed a commit addressing these.

I'd like to find an off the shelf configuration library that does variable substitition but haven't found one unfortunately (YAML doesn't do it), so I think I'll stick with the current hacky system for now