search

hammertater / treechop

MIT License
21 stars 9 forks source link

SimplyTools compat #217

Closed MelanX closed 10 months ago

MelanX commented 1 year ago

I got this issue: https://github.com/MelanX/SimplyTools/issues/9 As mentioned in this issue, the problem is caused by HT's TreeChop. This happens because the BreakEvent gets canceled because of this PreChopEvent cancelation: https://github.com/hammertater/treechop/blob/28f8ab3c9b62ad4e14b77d1e92e0245914177af6/forge/src/main/java/ht/treechop/compat/MultiMine.java#L34

This results in only breaking one block when breaking. Here you can see my implementation for breaking more than one block: https://github.com/MelanX/SimplyTools/blob/15225940638c03503fb1476294d5eeae53b68ba5/src/main/java/de/melanx/simplytools/util/BlockBreaker.java#L23-L38

MelanX commented 1 year ago

Setting multiMine config to false fixes the problem.

MelanX commented 1 year ago

Probably related to #214

hammertater commented 1 year ago

Thanks for reporting! Right, the line you pointed out is breaking everyone's AOE tools. I got all excited about finally fixing a Multi Mine-related bug and didn't think hard enough about the side effects. I'll post a fix as soon as I can.

hammertater commented 1 year ago

This should be fixed in 0.18.4, but I'll leave this issue open til I can confirm