hammertater / treechop

MIT License
16 stars 6 forks source link

[Incompatibility] Regions Unexplored brimwood_leaves #242

Closed KostromDan closed 7 months ago

KostromDan commented 7 months ago

Incompatibility with new biome(regions_unexplored:infernal_holt) trees from lastest Regions Unexplored major update. Decpite the fact that they have '#minecraft:leaves' tag. I've tried to add leaves to: image but doesn't helped. Replacing this leaves to any other fixes problem, so problem not with logs. image

hammertater commented 7 months ago

Thanks for reporting. Usually this is because the leaves are marked "persistent". Not sure what Minecraft version you're on, but in treechop 0.18.4 (only for 1.19.2 at the moment) you can add these kinds of misbehaving blocks to the lists in compatibility.trees.problematicLeavesTrees in treechop-common.toml and treechop will make sure to break them

KostromDan commented 7 months ago

Thanks for reporting. Usually this is because the leaves are marked "persistent". Not sure what Minecraft version you're on, but in treechop 0.18.4 (only for 1.19.2 at the moment) you can add these kinds of misbehaving blocks to the lists in compatibility.trees.problematicLeavesTrees in treechop-common.toml and treechop will make sure to break them

TreeChop-1.19.2-forge-0.18.4.jar Doesn't help. tried: "regions_unexplored:.*_leaves" "regions_unexplored:brimwood_leaves" image

KostromDan commented 7 months ago

Maybe related with this. https://github.com/UHQ-GAMES-MODS/REGIONS_UNEXPLORED_FORGE/issues/68

KostromDan commented 7 months ago

Also just noticed incorrect processing of redwood trees from this mod. image image

hammertater commented 7 months ago

Thanks for reporting. Usually this is because the leaves are marked "persistent". Not sure what Minecraft version you're on, but in treechop 0.18.4 (only for 1.19.2 at the moment) you can add these kinds of misbehaving blocks to the lists in compatibility.trees.problematicLeavesTrees in treechop-common.toml and treechop will make sure to break them

TreeChop-1.19.2-forge-0.18.4.jar Doesn't help. tried: "regions_unexplored:.*_leaves" "regions_unexplored:brimwood_leaves" image

Ah, you did it right, but I forgot to actually ignore persistence for "problematic leaves". Sorry about that! It's fixed in 0.18.5, fresh out of the oven.

Also just noticed incorrect processing of redwood trees from this mod.

Thanks for the screenshots! I've added redwoods to the list at https://github.com/hammertater/treechop/issues/44, and I'll close this issue since it's for the brimwoods