search

hammeruke / chordlab

A command line program to create pdf songbooks from chopro source.
http://rasmus.krats.se/2008/chordlab/en
0 stars 0 forks source link

Chord identity doesn't stop after first space #3

Closed spacehobo closed 10 years ago

spacehobo commented 10 years ago

At a meeting, @dvarrazzo said that chord parsing should stop at the first space, even if display continues past it. This allows us to type [D x1] and the system will include the chord box for a D and the advice to only play it once will appear as typed.

Unfortunately I don't believe this is working, because while I experimented with / as a stroke count marker I began to see:

WARNING Unknown chord: F / / /
WARNING Unknown chord: Dm / / /
WARNING Unknown chord: Dm /

So I think this is either a bug in code we think already does this, or a misunderstanding that invites the writing of this feature. Either way it's not a showstopper for anything. Our songbook doesn't call for chords often to be used only once so another line usually drags in the chord box.

dvarrazzo commented 10 years ago

Yep, I was wrong: It ignores everything in parens, so [D (once)] is taken as a D and [(Riff)] is ignored altogether. I've fixed the chords that were given warnings to make use of it (https://github.com/hammeruke/hug-chords/commit/9b06dbcff5d68f2350e7f2f0e03b053d7fbf667a).

I thought that covered everything... but not the stroke markers. I've explicitly whitelisted them, but if we come up with other decorations we want to stick in a chord we can just ignore everything after the first word as I thought it was doing.

Anyway, fixed in 854ceaec.