3ygun commented 7 years ago

Goal

Split BackgroundDataSend into more manageable classes:

DataSender -- Handles interactions with Firebase, is told the wifi state, and manages the workThread
DataComputer -- Contains the methods related to gradient and weight computation

This will help us going forward with the TensorFlow changes

Parts

[x] Split out into the 3 files
[x] Reduce code duplicated around workThread and params
[x] Creates LossFunction and Distribution on parameter creation not get call for improved get performance

This is a lot of changes so I may have messed something up
There is still refractoring work to be done don't think all of this should sit within ../utils/

tylermzeller commented 7 years ago

Are you ready to merge? This will help with my refactoring as well.

3ygun commented 7 years ago

Your call, I'm fine with it as a starting point but it's still quite rough just better than the old ~900 line file.

3ygun commented 7 years ago

I'm quite happy with the state of the DataSender.java I left the DataComputer.java more rough as I know you're looking to change it. LGTM