search

hammy275 / immersive-mc

A Minecraft mod to make Minecraft more immersive!
GNU Lesser General Public License v3.0
63 stars 9 forks source link

Genericize Crafting Table Detection #352

Open hammy275 opened 9 months ago

hammy275 commented 9 months ago

Already done for other blocks, should do it for crafting tables, too.

hammy275 commented 9 months ago

Done and done!

hammy275 commented 8 months ago

Had to undo the work from this due to a bug with smithing tables (see #371 ). I'm thinking of using a user-customizable whitelist in the future, but until then, this issue is back open.

hammy275 commented 5 months ago

I should use tags for this. Great system already in the game. I can internally keep a list of all crafting tables I know are supported, and it should let authors add their own through the vanilla tag system (will have to write a wiki article for that).

hammy275 commented 2 months ago

I should be able to detect crafting tables using each modloader's pre-existing crafting table tag combined with the new convention one (https://github.com/FabricMC/fabric/blob/e521378444edf1a1f4d41311b8be7edf2c17aef1/fabric-convention-tags-v2/src/generated/resources/data/c/tags/block/player_workstations/crafting_tables.json).

EyaeM commented 5 days ago

most crafting tables are not supported only (in my testing) the vanilla one works

hammy275 commented 4 days ago

Yes, this is planned to be fixed. At the moment, ImmersiveMC directly checks if the block is the vanilla crafting table, as other forms of detection that don't use tags end up catching other blocks that are built similarly (see the smithing table issue mentioned above).