search

hampgoodwin / iata-finder

Spec, Proto, and Scripts to etl, and access IATA airline information.
0 stars 0 forks source link

Add unit tests #24

Open JacobSNGoodwin opened 4 years ago

JacobSNGoodwin commented 4 years ago

add-unit-tests is a work in progress for feature requests in #23

For now, we have decided to just make sure that we have a non-empty response for GetAllAirlines and GetAllAirports.

If there are better suggestions (like checking that the response contains certain airports), I'd still be glad to take any tips on ways to test responses that are a slice of many structs.

JacobSNGoodwin commented 4 years ago

For now I decided to just load a single config file for testing and build.

If we want to create separate configs in a single file, I think it wouldn't be hard, but will just require some decisions around how to refactor rpcListen and loadConfig in the server. I think that could be merged in a separate PR

hampgoodwin commented 4 years ago

Cool. Sorry I've been slow on getting this reviewed, been busy with work >_<

hampgoodwin commented 4 years ago

Ok, I finally stopped being a bum and approved it. LMK if you have any Q's. I'll be available.