search

hampusborgos / country-flags

SVG and PNG renders of all countries' flags.
3.45k stars 978 forks source link

All flags in one PNG #122

Closed Ryszard-Trojnacki closed 1 year ago

Ryszard-Trojnacki commented 3 years ago

I have added a script that generates one big PNG file with all flags together with CSS and JSON files with informations about flag positions.

wyattoday commented 3 years ago

I haven't dug into your JS yet (I will when I have a chance), but my first broad comment is that it looks like the all.json/css/png files are generated from the JS, and thus shouldn't be included as part of the PR.

Ryszard-Trojnacki commented 3 years ago

I have removed generated files from PR (sorry for so many commits).

wyattoday commented 1 year ago

I was never able to get the JS to work. I'm on Windows using the latest NodeJS.

I'm closing this rather than leaving it dormant/abandoned.

If you do get it to work on Windows, I'll take a look at it again. Also, you might want to add more space between the "sprites" on the generated image. If you're using it in a browser you'll see "bleed" from bordering flags.