search

hampusborgos / country-flags

SVG and PNG renders of all countries' flags.
3.45k stars 978 forks source link

Remove Auto-Generated PNG Files #146

Open ludndev opened 1 year ago

ludndev commented 1 year ago

This pull request addresses the issue of auto-generated PNG files cluttering the repository. To improve maintainability and reduce unnecessary file storage, I have removed these auto-generated PNG files. Now, the repository is cleaner and more focused on its core purpose of providing country flags data.

Changes:

This cleanup not only enhances the repository's organization but also makes it easier for contributors to navigate and understand the codebase. Please review and merge this pull request at your earliest convenience.

JimmyCushnie commented 1 year ago

Having easy access to the PNGs is actually useful and convenient. I think they should stay.

This cleanup [...] makes it easier for contributors to navigate and understand the codebase.

This is a silly argument. Three folders of clearly labeled generated PNGs do not make it more difficult to navigate or understand this codebase.

wyattoday commented 1 year ago

I’ve contributed a fair bit to this repository in the past. A limiting factor and continual time-sink has been generating these mostly useless PNGs.

I’ve created an issue here: https://github.com/hampusborgos/country-flags/issues/143

I hesitate to unilaterally pull the trigger (because, although I’ve been doing a fair bit of work lately, it’s not “my” repository). Also, while there is a script to generate these PNGs it has never worked for me. And I don’t have the time or the willingness to fix the bugs.

I have some more changes and features coming, I might pull the trigger when I commit those.

ludndev commented 1 year ago

I believe removing the auto-generated PNG files and relying on SVG makes sense for a few key reasons:

  1. SVG has been widely supported since 2011, making it a mature and well-established format. All moderns browsers support it.

  2. SVG files are lightweight, saving both storage space and bandwidth.

  3. Users needing PNGs can generate them on their own or host SVG files on CDNs for efficient delivery. This approach aligns with modern development practices and standards.

wyattoday commented 1 year ago

I’ll accept this either when I make my next commit of fixes to flags. Or, if you can fix the script in this repository to correctly generate the PNGs.

ludndev commented 1 year ago

I have found a solution. I will make a pull request with a fully working script.

cdstanford commented 3 months ago

Many people use this repository purely to get the PNGs -- Please do not remove the autogenerated pngs!

wyattoday commented 3 months ago

A working script to autogenerate PNGs would be preferred.

I haven’t committed to this repository in a while, but I do have some pending changes. I think at the end of those pending changes I’ll delete the png files. Just a heads up.

Like I said above. It’s a headache for me to maintain as part of my commits, and is a mental impediment to committing more.

The actual solution is to fix the png generating script. But I don’t want to spend any of my time or money doing that.